Add Fail instance for Bind ZipList
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Data/List/ZipList.purs
Outdated
| instance alternativeZipList :: Alternative ZipList | ||
|
|
||
| instance zipListIsNotBind | ||
| :: Fail "ZipList is not Bind. Any implementation would break the associativity law" |
There was a problem hiding this comment.
It might make sense to suggest regular List here?
|
Thanks! |
|
Updated. Let me know if you'd like the error to be something else. Or if there's precedent somewhere, link me up 😄 |
|
New version looks nice! And I think you're setting the precedent here, we've not made use of this anywhere else yet. 😄 |
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.